XChange icon indicating copy to clipboard operation
XChange copied to clipboard

Published 20 hours ago • verified publisher icon knowm

[Bittrex] Place Market Order

Open garciapd opened this issue 3 years ago • 5 comments

Implement place market order for Bittrex

garciapd avatar Apr 18 '21 21:04 garciapd

You didn't address 2/3 of my comments?

earce avatar Apr 26 '21 12:04 earce

@earce is it ok now? Thanks for reviewing

garciapd avatar May 05 '21 21:05 garciapd

I had a fix for bitfinex too mixed in the branch, could you please check if the code as it is good enough? i separated the api call from the logic. Bittrex sometimes takes a few millis to get you the order with the price, that is why the retries...

garciapd avatar Aug 29 '21 16:08 garciapd

I'd merge this expect for the retries. That can be done outside of this lib.

timmolter avatar Nov 02 '21 18:11 timmolter

it would be best for now to ommit those retries or implement them in this fashion https://github.com/knowm/XChange/wiki/Implementing-resiliency-features

however does the originam author have the time to polish this PR?

if not I will have to close it

walec51 avatar Jul 30 '23 12:07 walec51