Matej Knopp

Results 29 issues of Matej Knopp

[Original reland](https://github.com/flutter/engine/pull/51126) was [reverted](https://github.com/flutter/engine/commit/78cecee7fb1fa1ec8c8058e9b726ef12d2d38893) because of skiaperf regressions. The regressions are caused by runner machines running display at 30hz. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and...

waiting for tree to go green
affects: desktop
platform-macos

Fixes https://github.com/flutter/flutter/issues/129085 ## Changes to `FlutterMouseCursorPlugin` - `none` cursor is not handled by hiding the cursor anymore. That was too big of a hammer as it also affects other views...

affects: desktop
platform-macos

[super_sliver_list](https://superlistapp.github.io/super_sliver_list/#/example/item-list) is an alternative to `SliverList` (and `ListView`) with different performance characteristics and ability to reliably jump / animate to any item. It relies heavily on `scrollOffsetCorrection` in a way...

Seems like a regression in current main. `flutter run -d macos` will try to build native assets. `flutter build macos` will *not* try to build native assets cc @dcharkes

https://en.wikipedia.org/wiki/High_Efficiency_Image_File_Format https://en.wikipedia.org/wiki/JPEG_XL

`compile_commands.json`: (contains `-fobjc-arc`) ``` { "file": "../../flutter/shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm", "directory": "/Users/Matej/Projects/flutter/engine/src/out/host_debug_unopt_arm64", "command": "../../flutter/buildtools/mac-x64/clang/bin/clang++ -MMD -MF obj/flutter/shell/platform/darwin/macos/framework/Source/flutter_framework_source.FlutterSurfaceManager.o.d -DFLUTTER_FRAMEWORK -DFLUTTER_ENGINE_NO_PROTOTYPES -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_AVAILABILITY=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D_DEBUG -DSK_TYPEFACE_FACTORY_CORETEXT -DSK_FONTMGR_CORETEXT_AVAILABLE -DSK_GL -DSK_METAL -DSK_ENABLE_DUMP_GPU -DSK_CODEC_DECODES_JPEG...

When native assets build.dart fails during `flutter build`, its output should be printed. This doesn't currently happens consistently. macOS (xcodebulld): - stdout is printed - stderr is printed twice linux...

tool
P2
team-tool
triaged-tool

Happens with current main (3.22.0-16.0.pre.26). Widget test to reproduce: ```dart testWidgets('FocusScope descendantsAreFocusable', (WidgetTester tester) async { final focusScopeNode = FocusScopeNode(); await tester.pumpWidget( FocusScope( node: focusScopeNode, child: const SizedBox.shrink(), ), );...

a: tests
framework
f: focus
has reproducible steps
P2
team-framework
triaged-framework
found in release: 3.19
found in release: 3.22

Currently App.framework and FlutterMacOS.framework are codesigned in `macos_assemble.sh`: https://github.com/flutter/flutter/blob/607a3dad768d326fb9fb1ac24e6a2fc92303a6ab/packages/flutter_tools/bin/macos_assemble.sh#L180-L183 I think same thing should be done for native assets, otherwise they keep the adhoc signature, which fails to load at...

tool
platform-mac
a: build
team-tool