Matej Knopp

Results 169 comments of Matej Knopp

Update: This is currently blocked on Infra. I've provided a test application which should help us determine whether the regression is caused by the PR or runner.

The clock issue is fixed in this PR. It properly converts `CAMediaTime` to engine time and back.

This is not a recent regression, but I think in our app we trigger rebuild in `_ModalScopeState` while the `canRequestFocus` property is set to `false` on the scope focus node,...

My issue here is that it modifies completely unrelated property but doesn't set it back. And the behavior depends on whether the widget gets rebuilt or not, which is quite...

As for default constructor not taking a node, that would be a pretty major breaking change. Though TBH the `withExternalFocusNode` constructor was always a bit confusing to me considering that...

@gspencergoog, in this case it's not *me* modifying it, but modal route in the framework: https://github.com/flutter/flutter/blob/65e657799fb596bf39bdc1e62756fa1f9c416efe/packages/flutter/lib/src/widgets/routes.dart#L1071 Should it be fixed to use `withExternalFocusNode`? Also, is there a valid use-case for...

@gspencergoog, I think something similar to https://github.com/flutter/flutter/issues/146844 should work? For us the problem also manifested when using the backswipe gesture on iOS. I'm guessing something there triggers the rebuild in...

Yeah, this definitely seems like something I'm going to need to spend a weekend on. Especially on windows the situation is pretty bad because the error is either swallowed completely...

Sorry, accidentally replied this instead of the [NativeShell issue](https://github.com/nativeshell/nativeshell/issues/60). Can you reply there?