knope icon indicating copy to clipboard operation
knope copied to clipboard

feat: Add confirm step type

Open alex-way opened this issue 1 year ago β€’ 3 comments

Closes #953

Provides functionality to allow prompts with confirmation before proceeding with the remainder of the workflow.

Dry-run functionality will simply print a message saying that it will prompt the users with the message provided in the knope.toml configuration.

  • [ ] Refactor confirm function to make testing easier
  • [ ] Add unit tests
  • [x] Add documentation for confirm step type
  • [x] Add auto-confirmation functionality (-y in the CLI)
  • [x] Add documentation for -y flag

alex-way avatar Mar 28 '24 09:03 alex-way

Deploy Preview for knope canceled.

Name Link
Latest commit 245408fbe38b6b73626f6f73e8d4066bf723245d
Latest deploy log https://app.netlify.com/sites/knope/deploys/663a8e01efa2690008b534e0

netlify[bot] avatar Mar 28 '24 09:03 netlify[bot]

@dbanty Would it be wise to wait until #920 is merged until adding any unit tests into this one? The core functionality is there, just tests currently missing

alex-way avatar Mar 28 '24 18:03 alex-way

#920 might be in limbo for a little bitβ€”it's powering a new feature for the GitHub bot, but I don't have time to finish the feature for a few weeks πŸ˜“.

dbanty avatar Mar 28 '24 20:03 dbanty