pubsubclient icon indicating copy to clipboard operation
pubsubclient copied to clipboard
verified publisher icon knolleary

bugfix for keep alive zero

Open ChuckMash opened this issue 2 years ago • 4 comments

Setting keep alive to 0, or infinite keep alive, is not currently handled correctly. Currently the client will immediately disconnect when keep alive is set to 0, this fix adds a check for this state before attempting PINGREQ.

Solves #1033

ChuckMash avatar Dec 10 '23 17:12 ChuckMash

Hey @knolleary would you be able to review/merge this oneliner bugfix? It would save A LOT of reconnections for all of us! Thanks :)

damdo avatar Jan 12 '24 11:01 damdo

Unfortunately there are so may undone pull requests here that one can believe that @knolleary dropped support of this repo. Maybe it's good to do a PR at https://github.com/thingsboard/pubsubclient as they promised to support development on this library.

hmueller01 avatar Jan 12 '24 20:01 hmueller01

@hmueller01 opened a PR there: https://github.com/thingsboard/pubsubclient/pull/7

damdo avatar Jan 14 '24 14:01 damdo