fastlane-plugin-ionic_integration icon indicating copy to clipboard operation
fastlane-plugin-ionic_integration copied to clipboard

Questions for understanding the code

Open janpio opened this issue 6 years ago • 2 comments

Looking at the code right now, trying to understand some things. I know this is quite old now, but maybe you still remember:

  1. ionic_ios_config_snapshot_action copies the test files for one scheme name (ui-snapshots by default). But then ionic_ios_snapshot_action loops over all schemes it finds. Why is that?

  2. Why is this output when it opens the project? https://github.com/knocknarea/fastlane-plugin-ionic_integration/blob/67c31c2f5f20408a634d2ac873f595941a14437e/lib/fastlane/plugin/ionic_integration/actions/ionic_ios_snapshot_action.rb#L43

  3. Why is ionic_min_target_os a parameter? Where and why would one need this?

  4. Why the configurable scheme name? Is there any use to be able to give this a specific name that I don't see (yet)?

janpio avatar Aug 03 '18 16:08 janpio

  1. Why the separation into two actions?

janpio avatar Aug 04 '18 10:08 janpio

'1) and 4) are probably to enable adding of multiple "test suites". The first action just creates new files under a specified "scheme name", the other then works with all schemes it can find to integrate them into the project.

janpio avatar Aug 06 '18 21:08 janpio