knix icon indicating copy to clipboard operation
knix copied to clipboard

Ansible Makefile doesnt seem to like being in a directory with spaces in the filename

Open MoralCode opened this issue 1 year ago • 1 comments

when trying to bring up knix with one host (a VM) I got stuck with the following error (actual file path redacted):

$ make
cd ../../riak && make lib/jiffy.tgz && cd -
make[1]: Entering directory '/path/to/Some Directory/that/Contains A Few/spaces/riak'
mkdir -p lib
echo "Building jiffy"
Building jiffy
Container image riak_libs_build:0.9.0-29-g4c8f006-dirty is already up-to-date
docker run -i --rm -u $(id -u):$(id -g) -v /path/to/Some Directory/that/Contains A Few/spaces/riak:/temp -w /temp --ulimit nofile=262144:262144 riak_libs_build:0.9.0-29-g4c8f006-dirty cp /build/jiffy.tgz ./lib/.
docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.
make[1]: *** [Makefile:27: lib/jiffy.tgz] Error 125
make[1]: Leaving directory '/path/to/Some Directory/that/Contains A Few/spaces/riak'
make: *** [Makefile:50: ../../riak/knix_riak_deployment_package.tar.gz] Error 2

I was able to locate the spot where i could enclose the path path (-v /path/to/Some Directory/that/Contains A Few/spaces/riak:/temp) in quotes to allow it to handle file paths containing spaces

MoralCode avatar Mar 23 '24 16:03 MoralCode

Thanks for the PR. I am not sure this is a critical requirement; it's more like a personal style to have spaces in directory names (and in many UNIX variants, usually against the general convention).

We'll let the PR stay in case anyone needs it.

Thanks again!

iakkus avatar Apr 23 '24 08:04 iakkus