Yuji Kanagawa comments

Results 88 comments of


                                            Yuji Kanagawa

Enable new Rust code coverage instrumentation

@LiquidityC Thank you for your nice example! We use it at https://github.com/PyO3/pyo3

FFI module cleanup

I was thinking of removing those comments and appreciate your help. 👍🏼

Nested import groups (stable in 1.25) break completion

I think it should work since #854. What's your racer's(or rls's) version?

Nested import groups (stable in 1.25) break completion

Please let me know the output of ``` rls --version ```

Nested import groups (stable in 1.25) break completion

I can't reproduce. If you still has any problem, please add `"rust-client.logToFile": true` to vs-code setting and open it with `env RUST_LOG=rls=debug` and upload the log file. Sorry to have...

Nested import groups (stable in 1.25) break completion

> across 3 windows machines but not on my Mac Sounds weird... Thanks for reporting.

racer got lost after reqwest::timeout

Thanks for reporting!

Jump-to-definition is broken in rust 2018 edition

I think it works in most cases though I know the implementaion is not correct. It just ignores `crate` to reuse 2015 style path resoltion code...

Now in libsyntax TyKind is defined as ```rust pub enum TyKind { Slice(P), Array(P, AnonConst), Ptr(MutTy), Rptr(Option, MutTy), BareFn(P), Never, Tup(Vec ), Path(Option, Path), TraitObject(GenericBounds, TraitObjectSyntax), ImplTrait(NodeId, GenericBounds), Paren(P), Typeof(AnonConst),...

Refator 'Ty'

Thanks! But I fear currently the situation is a bit complicated. Impl trait is treated as TraitObject like you can see at [this line](https://github.com/racer-rust/racer/blob/19c3e49a390005f062131267a7afe6bba37ff582/src/racer/ast_types.rs#L133). Yeah maybe we need refactoring around...