knex icon indicating copy to clipboard operation
knex copied to clipboard

Proper support for Typescript and ESM by migrating to better libraries/frameworks.

Open damianobarbati opened this issue 4 months ago • 5 comments

I see many problems in this wonderful library adding proper typescript and esm support.

I strongly invite you to consider migrating from:

  • Jest to Vitest
  • ts-node / ts-register to tsx

vitest and tsx properly support both typescript and ESM, which are a must nowadays.

damianobarbati avatar Feb 09 '24 13:02 damianobarbati

underrated issue 👆

emilioSp avatar Feb 09 '24 14:02 emilioSp

PRs are very welcome!

kibertoad avatar Feb 09 '24 15:02 kibertoad

@kibertoad I'd be glad to work on it, but before investing so much effort in it I'd like to ask you: is there an intention to actually push this from the maintainers' side? Furthermore, did you consider moving to an ESM-first lib?

damianobarbati avatar Feb 09 '24 16:02 damianobarbati

ESM-first no. I've tried to create a ESM-only webservice as recently as this week, and tooling is still not there. I'm open to dual-publish of ESM+CommonJS.

kibertoad avatar Feb 09 '24 16:02 kibertoad

@kibertoad which tooling are you referring too? Just to share your experience/knowledge.

damianobarbati avatar Feb 12 '24 10:02 damianobarbati