documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Published 20 hours ago • verified publisher icon knex

Add PostgreSQL schema functions

Open jamarzka opened this issue 7 years ago • 4 comments

jamarzka avatar Jan 30 '18 21:01 jamarzka

Hi, thanks for PR. Are these functions already implemented? Is there any related issues?

elhigu avatar Jan 31 '18 08:01 elhigu

Yes these functions are already implemented for PostgreSQL: https://github.com/tgriesser/knex/blob/master/src/dialects/postgres/schema/compiler.js#L67

No related issues that I'm aware of. This is the original PR when the schema support was added: https://github.com/tgriesser/knex/pull/518

jamarzka avatar Feb 01 '18 17:02 jamarzka

@jamarzka Thanks for the reference to PR.

I just looked into it and didn't see any tests for createSchemaIfNotExists, dropSchemaIfExists, createSchema, dropSchema so I'd rather not make them official features until there are some tests made written for them. These are so simple queries, that I'm fine with plain unit tests.

elhigu avatar Feb 01 '18 23:02 elhigu

The website repo has been moved inside the https://github.com/knex/knex repo. Please open a PR there instead: (the website will be under the docs folder)

rluvaton avatar Mar 02 '24 20:03 rluvaton