nvim-dbee
nvim-dbee copied to clipboard
kndndrj
feat: databricks adapter
What has changed
- new adapter for databricks SQL warehouse by utilising https://github.com/databricks/databricks-sql-go
- new core structure function
- extended candies for UI
since #80 was rejected-- what steps can I take to get this one across the finish line?
since #80 was rejected-- what steps can I take to get this one across the finish line?
I just don't see the point of adding a for-loop which can be done on the user side. So from my point of view, let's remove those changes from this PR.
Other than that, I'm not sure what needs to be done on the go side.
Maybe @MattiasMTS can elaborate.
Ah sorry I totally missed this.
Yea I agree with @kndndrj that the #80 commit will be removed.
I've left some TODOs in the description. Give me some time and I can get this in. @bcp-dev-ops whats the urgency?
Should be ready for review now @kndndrj.
I refactored some of the core stuff, e.g. getPGStructure since we are re-using this more than just the postgres adapter at this point.
Also, extended the candies a bit and added some default icons for stuff. Not sure how elegant this is given that some types only exist for some adapters. This could need some thinking but for now I don't want to create a breaking change in the lua config. Feel free to change the icons I added -> for now we separate e.g. "materialized view" from "view" by colors etc.
@bcp-dev-ops let me know if this works for you.
Works like a charm! Thanks @MattiasMTS
@kndndrj can you consider for merging?
Noticed that there are discrepancies in when the helper functions show, in regards to table vs view. Is this a databricks adapter issue, or a plugin issue?
@kndndrj any objections on getting this in to unblock #77 (if it is still relevant)
@MattiasMTS do you use this branch on your side as this project doesn't seem actively maintained?
@MattiasMTS do you use this branch on your side as this project doesn't seem actively maintained?
I haven't been working on this branch in particular but it should be sufficient to use for your daily SQL warehouse work. I'll try to fix the comments that @phdah has brought up ones this becomes available to be meged.
The project is maintained but I understand that the owner has a lot on his plate with work and other stuff going on. It's not fair to push someone to get it merged unless the person has the resources to do it. Nevertheless, it is open source.
For now, I'd say you can try and checkout this branch locally, build it and install via go installation and try it out.