nvim-dbee icon indicating copy to clipboard operation
nvim-dbee copied to clipboard

chore: update `Structure` and `Columns` for duckdb driver

Open MattiasMTS opened this issue 1 year ago • 7 comments

🏗️ what has changed 🏗️

  • Updated the Structure and Columns method for duckdb driver based on https://duckdb.org/docs/sql/information_schema.html.
  • updated the duckdb go driver to latest (v1.5.6)

Using this as testing for the autocompletion plugin 😋

MattiasMTS avatar Jan 22 '24 20:01 MattiasMTS

Overall changes look good!

But (yes, sorry 😅) I think I noticed somewhere that duckdb versions won't be backwards compatible before v1. So it probably makes sense to keep the previous version until v1. Correct me if I'm wrong though :)

Otherwise this can get merged.

kndndrj avatar Apr 09 '24 04:04 kndndrj

Overall changes look good!

But (yes, sorry 😅) I think I noticed somewhere that duckdb versions won't be backwards compatible before v1. So it probably makes sense to keep the previous version until v1. Correct me if I'm wrong though :)

Otherwise this can get merged.

Ok, so we make a new driver for v1?

MattiasMTS avatar Apr 09 '24 14:04 MattiasMTS

Are these changes relevant for current version as well?

kndndrj avatar Apr 09 '24 15:04 kndndrj

Are these changes relevant for current version as well?

Hmm not sure. I think so but I can double check whenever I've some time.

MattiasMTS avatar Apr 09 '24 17:04 MattiasMTS

Hey, @MattiasMTS

It has come to my attenrion that version 0.10 of duckdb started backwards compatibility.

So if you can update to the latest driver and verify that everything works, this PR is good to go!!

kndndrj avatar May 03 '24 09:05 kndndrj

Hey, @MattiasMTS

It has come to my attenrion that version 0.10 of duckdb started backwards compatibility.

So if you can update to the latest driver and verify that everything works, this PR is good to go!!

Gotcha. I’ll try to carve out some time later today after work. Cheers.

MattiasMTS avatar May 03 '24 10:05 MattiasMTS

I think it make more sense to merge this after merging #89. Mainly because I've introduced some core changes in the latter for the Structure func.

Let me know whatya think @kndndrj

MattiasMTS avatar May 03 '24 19:05 MattiasMTS