knative
[WIP] Initial setup for running the website in Docker
Changes
- Adds documentation on how to run in Docker
/kind documentation
Fixes #
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign abrennan89 after the PR has been reviewed.
You can assign the PR to them by writing /assign @abrennan89 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Looking on feedback:
- Where should this live, is this the right directory or should we put this in Docs
- I'm editing scripts used to build the site and am including them with the docker build option - should we build an image and host it in dockerhub - do we have a knative dockerhub user?
- Interested in any feedback on building the image - I'm using a larger base and am installing the Hugo version we use to make sure that we have extended. The image is around 695MB right now.
Addressed the review requests. Looking for more feedback on where this should live, right now it's website/docker. I don't know if that will cause any issues. It looks like the tests are failing right now due to another issue related to an addition recently.
@mpetason: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.