website icon indicating copy to clipboard operation
website copied to clipboard

Add StackOverflow Link to bottom of homepage

Open omerbensaadon opened this issue 4 years ago • 4 comments

Screen Shot 2021-03-23 at 9 43 20 AM

Would be great to add a link to StackOverflow at the bottom here...

Where would I PR this change?

CC: @RichieEscarez

omerbensaadon avatar Mar 23 '21 13:03 omerbensaadon

This is one of the dynamic template pages.

The new content would be added to this list in the config file: https://github.com/knative/website/blob/main/config/_default/params.toml#L70

Do remember to test all screen sizes (I expect some word cut-off might happen when adding more to that row, which would require some tweaking).

RichieEscarez avatar Mar 25 '21 01:03 RichieEscarez

thanks @RichieEscarez I'll throw this on the To Do List

omerbensaadon avatar Mar 25 '21 11:03 omerbensaadon

@RichieEscarez wait I am confused...

What you linked me to doesn't look like it appears on the homepage...? I don't see any of the copy ("Interested in learning more, speaking to other contributors..." etc)

omerbensaadon avatar Mar 26 '21 13:03 omerbensaadon

Sorry, that is the footer for all other pages so you need to add/update the footer in both places.

Here is the main site index (it was moved to knative/website to also protect it from change since it had "marketing" language) https://github.com/knative/website/blob/main/content-override/en/_index.html

RichieEscarez avatar Mar 29 '21 20:03 RichieEscarez