specs icon indicating copy to clipboard operation
specs copied to clipboard

Mention management of `metadata.generation` and `status.observedGeneration`.

Open evankanderson opened this issue 4 years ago • 3 comments

Document management of status.observedGeneration and client behavior from this comment.

TODO: experiment whether mutating webhooks could actually clear Conditions during PATCH of spec. If so, update webhooks and then we can remove this section.

evankanderson avatar Jul 25 '21 17:07 evankanderson

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot avatar Jul 25 '21 17:07 knative-prow-robot

TODO: experiment whether mutating webhooks could actually clear Conditions during PATCH of spec. If so, update webhooks and then we can remove this section.

I believe Webhooks being invoked for spec changes can't update the status. They are separate invocations since /status is a subresource

dprotaso avatar Mar 26 '24 16:03 dprotaso

@evankanderson do you still want this PR to merge? I didn't see a reply to @duglin's comment.

dprotaso avatar Mar 26 '24 16:03 dprotaso