Add terminationGracePeriodSeconds support to user and sidecar container probes (#15823)

[flomedja]

Fixes #

#15823

Proposed Changes

Add terminationGracePeriodSeconds in the probe Mask used for the container probes. This will allw it to be configurable for the container probes. I add the issue https://github.com/knative/serving/issues/16256 to validate the the startup probes for user and sidecar containers.

Release Note

Add  `terminationGracePeriodSeconds` support for user and sidecar container probes

[knative-prow[bot]]

Hi @flomedja. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 80.06%. Comparing base (6d9d1b6) to head (3ee3f3a). :warning: Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16255      +/-   ##
==========================================
- Coverage   80.09%   80.06%   -0.03%     
==========================================
  Files         215      215              
  Lines       13361    13362       +1     
==========================================
- Hits        10701    10698       -3     
- Misses       2300     2304       +4     
  Partials      360      360              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[flomedja]

@dsimansk @skonto Can you help to rerun the failed e2e test ?

[linkvt]

/retest

[linkvt]

/ok-to-test

[flomedja]

@dsimansk @skonto just a little reminder for the review :)

[dprotaso]

/retest

[dprotaso]

/lgtm /approve

thanks for the change

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, flomedja

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~pkg/apis/OWNERS~~ [dprotaso]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/retest