serving icon indicating copy to clipboard operation
serving copied to clipboard

Fix race condition in timeout handler causing activator crashes

Open Fedosin opened this issue 2 months ago • 2 comments

Fixes #15850

Proposed Changes

Add synchronization for HTTP header map access during request timeouts. When a timeout occurs, capture a snapshot of headers to prevent concurrent modification by the inner handler after the timeout handler returns.

Release Note

NONE

Fedosin avatar Nov 05 '25 13:11 Fedosin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Nov 05 '25 13:11 knative-prow[bot]

Codecov Report

:x: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 80.10%. Comparing base (41fafd1) to head (a2e2dde). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/http/handler/timeout.go 76.92% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16222      +/-   ##
==========================================
+ Coverage   80.04%   80.10%   +0.06%     
==========================================
  Files         214      214              
  Lines       13313    13325      +12     
==========================================
+ Hits        10656    10674      +18     
+ Misses       2296     2292       -4     
+ Partials      361      359       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 05 '25 13:11 codecov[bot]