serving
serving copied to clipboard
Fix linter suggestions
Fixes #15755
Proposed Changes
For the specific case described here, we now check for a NotFound error and return an empty list.
Release Note
NONE
linter changes are already part of this PR - https://github.com/knative/serving/pull/15922
/hold
can you just fix the Check NotFound error when we get certificates in this PR
Codecov Report
Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
Project coverage is 80.90%. Comparing base (
c50a00d) to head (68ba69c). Report is 9 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/reconciler/route/route.go | 0.00% | 7 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #15924 +/- ##
==========================================
- Coverage 80.98% 80.90% -0.08%
==========================================
Files 210 210
Lines 16780 16784 +4
==========================================
- Hits 13589 13579 -10
- Misses 2839 2850 +11
- Partials 352 355 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Fedosin Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Just realized that we call List, not Get. List doesn't return NotFound errors, so your fix with //nolint is more correct.