serving icon indicating copy to clipboard operation
serving copied to clipboard

Fix linter suggestions

Open Fedosin opened this issue 5 months ago • 5 comments

Fixes #15755

Proposed Changes

For the specific case described here, we now check for a NotFound error and return an empty list.

Release Note

NONE

Fedosin avatar Jun 11 '25 22:06 Fedosin

linter changes are already part of this PR - https://github.com/knative/serving/pull/15922

dprotaso avatar Jun 11 '25 22:06 dprotaso

/hold

can you just fix the Check NotFound error when we get certificates in this PR

dprotaso avatar Jun 11 '25 22:06 dprotaso

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (c50a00d) to head (68ba69c). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/route/route.go 0.00% 7 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15924      +/-   ##
==========================================
- Coverage   80.98%   80.90%   -0.08%     
==========================================
  Files         210      210              
  Lines       16780    16784       +4     
==========================================
- Hits        13589    13579      -10     
- Misses       2839     2850      +11     
- Partials      352      355       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 11 '25 22:06 codecov[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 11 '25 23:06 knative-prow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Jun 13 '25 01:06 knative-prow-robot

Just realized that we call List, not Get. List doesn't return NotFound errors, so your fix with //nolint is more correct.

Fedosin avatar Jun 23 '25 10:06 Fedosin