serving icon indicating copy to clipboard operation
serving copied to clipboard

POC: use libkpa autoscaler instead of the built-in implementation

Open Fedosin opened this issue 5 months ago • 2 comments

Fixes #

Proposed Changes

Release Note


Fedosin avatar Jun 11 '25 15:06 Fedosin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 11 '25 15:06 knative-prow[bot]

Codecov Report

Attention: Patch coverage is 74.48980% with 25 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (cada0f4) to head (e7c01f5). Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
pkg/autoscaler/scaling/libkpa_autoscaler.go 73.95% 17 Missing and 8 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15923      +/-   ##
==========================================
- Coverage   80.98%   80.93%   -0.06%     
==========================================
  Files         210      211       +1     
  Lines       16780    16876      +96     
==========================================
+ Hits        13590    13658      +68     
- Misses       2838     2856      +18     
- Partials      352      362      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 11 '25 15:06 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Jul 13 '25 15:07 knative-prow-robot