serving icon indicating copy to clipboard operation
serving copied to clipboard

Clean up certificate leases

Open skonto opened this issue 1 year ago • 5 comments

Fixes https://github.com/knative/serving/issues/15238

Proposed Changes

  • See https://github.com/knative/serving/pull/15321#issuecomment-2176434523
  • After deleting pods the new ones will not set any lease but we want to make sure old relics are removed.
  • This is temporary until client-go lib fixes this, https://github.com/kubernetes/client-go/issues/1362.

skonto avatar Jun 26 '24 11:06 skonto

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.62%. Comparing base (1dff15d) to head (c3984c1). Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15359      +/-   ##
==========================================
+ Coverage   84.59%   84.62%   +0.02%     
==========================================
  Files         219      219              
  Lines       13584    13584              
==========================================
+ Hits        11492    11496       +4     
+ Misses       1726     1724       -2     
+ Partials      366      364       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 26 '24 11:06 codecov[bot]

/test istio-latest-no-mesh

skonto avatar Jun 26 '24 13:06 skonto

/test all

dprotaso avatar Jun 26 '24 17:06 dprotaso

/test istio-latest-no-mesh

skonto avatar Jun 26 '24 20:06 skonto

@dprotaso could you merge if no objection?

skonto avatar Jul 04 '24 12:07 skonto

/lgtm /approve

dprotaso avatar Jul 11 '24 15:07 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [dprotaso,skonto]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jul 11 '24 15:07 knative-prow[bot]

@skonto do you think we need to revert any of your earlier work regarding this flake?

dprotaso avatar Jul 11 '24 17:07 dprotaso