serving icon indicating copy to clipboard operation
serving copied to clipboard

Add e2e test for Contour when CORS policy is enabled

Open izabelacg opened this issue 1 year ago • 4 comments

Proposed Changes

  • Add e2e test for Contour when CORS policy is enabled

Release Note


izabelacg avatar May 06 '24 17:05 izabelacg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.79%. Comparing base (c2d0af1) to head (e1ea600). Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15188      +/-   ##
==========================================
+ Coverage   84.11%   84.79%   +0.67%     
==========================================
  Files         213      218       +5     
  Lines       16783    13469    -3314     
==========================================
- Hits        14117    11421    -2696     
+ Misses       2315     1682     -633     
- Partials      351      366      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 17:05 codecov[bot]

/hold for others to review

izabelacg avatar May 06 '24 17:05 izabelacg

Thanks :pray:

krsna-m avatar May 06 '24 19:05 krsna-m

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: izabelacg, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 13 '24 08:05 knative-prow[bot]

/hold cancel

izabelacg avatar May 13 '24 14:05 izabelacg

We should move this e2e test to net-contour - given it's specific to only that integration

dprotaso avatar May 21 '24 15:05 dprotaso