serving
serving copied to clipboard
[WIP] Fix tests for revision timeouts
Relates to #15089
~~* delete ./test/conformance/api/v1/revision_timeout_test.go since it is identical to ./test/e2e/timeout_test.go except for TestRevisionTimeout/writes_first_byte_before_timeout~~ (learned that e2e and conformance aren't necessarily interchangeable)
- fix expected status code for TestRevisionTimeout/writes_first_byte_before_timeout and move/rename it to TestRevisionTimeout/exceeds_total_timeout_after_first_byte
- propose new TestRevisionTimeout/exceeds_idle_timeout that sets sleep time instead of initialSleep
Release Note
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.76%. Comparing base (
c2d0af1
) to head (cede1ec
). Report is 101 commits behind head on main.
:exclamation: Current head cede1ec differs from pull request most recent head e42c706. Consider uploading reports for the commit e42c706 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #15181 +/- ##
==========================================
+ Coverage 84.11% 84.76% +0.65%
==========================================
Files 213 218 +5
Lines 16783 13469 -3314
==========================================
- Hits 14117 11417 -2700
+ Misses 2315 1686 -629
- Partials 351 366 +15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: izabelacg Once this PR has been reviewed and has the lgtm label, please assign davidhadas for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@izabelacg: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
unit-tests_serving_main | e42c706ed2ae62587c0bbc5f17a814e3d8bbbf30 | link | true | /test unit-tests |
istio-latest-no-mesh_serving_main | e42c706ed2ae62587c0bbc5f17a814e3d8bbbf30 | link | true | /test istio-latest-no-mesh |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@izabelacg: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
unit-tests_serving_main | e42c706ed2ae62587c0bbc5f17a814e3d8bbbf30 | link | true | /test unit-tests |
istio-latest-no-mesh_serving_main | e42c706ed2ae62587c0bbc5f17a814e3d8bbbf30 | link | true | /test istio-latest-no-mesh |
certmanager-integration-tests_serving_main | e42c706ed2ae62587c0bbc5f17a814e3d8bbbf30 | link | true | /test certmanager-integration-tests |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen
. Mark as fresh by adding the
comment /remove-lifecycle stale
.