serving icon indicating copy to clipboard operation
serving copied to clipboard
verified publisher icon knative

Set the appropriate h2c appProtocol label so our K8s Services work with Gateway API

Open dprotaso opened this issue 2 years ago • 2 comments

Feature Request

Currently we are not setting known appProtocol values to indicate our backends expect a certain protocol. This is the mechanic used by Gateway API implementations

ref: https://github.com/istio/istio/issues/47610 ref: https://github.com/projectcontour/contour/issues/5897

I think we should start with h2c first since we have a mechanic defined in our runtime contract to specify that protocol.

For websocket - this in theory should just be on by default (contour toggled it on for Gateway API). There might be other implementations that have this off but let's revisit that when we find one that doesn't

dprotaso avatar Oct 26 '23 19:10 dprotaso

/assign

gabo1208 avatar Nov 06 '23 11:11 gabo1208

Interestingly enough I wonder if adding the app protocol broke net-gateway-api

see the dependency bump here: https://github.com/knative/serving/pull/14789

dprotaso avatar Jan 15 '24 21:01 dprotaso

Verified with the networking conformance that this should work now with our net-gateway-api integration

https://github.com/knative-extensions/net-gateway-api/pull/635

dprotaso avatar Mar 05 '24 20:03 dprotaso