serving icon indicating copy to clipboard operation
serving copied to clipboard

Feature: added PodSpec.HostIPC extension

Open pablocael opened this issue 1 year ago • 4 comments

Fixes #

Proposed Changes

Add extension to enable hostIPC in pod spec. This is necessary to run gpu jobs using VGPUs in kserve. Kserve already allows this spec in InferenceService, but its not copied to pod spec of revision deployment by knative. This PR enables a new extension in config-features to allow hostIPC to be used.

Related: https://github.com/knative/serving/issues/12830#issue-1196602731

Release Note

Add feature extension to enable hostIPC in pod specs.

pablocael avatar Sep 17 '22 06:09 pablocael

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: pablocael / name: Pablo Carneiro Elias (d1eecc7e51628ec6defd1982f3b4cbac313b2989)

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pablocael Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval by writing /assign @psschwei in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Sep 17 '22 06:09 knative-prow[bot]

Welcome @pablocael! It looks like this is your first PR to knative/serving 🎉

knative-prow[bot] avatar Sep 17 '22 06:09 knative-prow[bot]

Hi @pablocael. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Sep 17 '22 06:09 knative-prow[bot]

/ok-to-test

psschwei avatar Sep 26 '22 21:09 psschwei

@pablocael: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_serving_main d1eecc7e51628ec6defd1982f3b4cbac313b2989 link true /test unit-tests
upgrade-tests_serving_main d1eecc7e51628ec6defd1982f3b4cbac313b2989 link true /test upgrade-tests
istio-latest-no-mesh_serving_main d1eecc7e51628ec6defd1982f3b4cbac313b2989 link true /test istio-latest-no-mesh

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

knative-prow[bot] avatar Sep 26 '22 22:09 knative-prow[bot]