Make conformance tests configurable with custom resource values

[norman465]

In response to https://github.com/knative/specs/pull/104

Proposed Changes

• make conformance tests requiring specific resource requests/limits configurable so that an installation can deviate from the defaults

Release Note

 NONE

Changes are analog to ExceedingMemoryLimitSize https://github.com/knative/serving/blob/19cd295c460137ea7f071da449bef08f45c6f928/test/e2e_flags.go#L49 IMO ExceedingMemoryLimitSize is now superfluous, but I don't have enough overview to know for certain.

[knative-prow[bot]]

Hi @norman465. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov[bot]]

Codecov Report

Base: 86.51% // Head: 86.46% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (907fc93) compared to base (62685b3). Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13286      +/-   ##
==========================================
- Coverage   86.51%   86.46%   -0.05%     
==========================================
  Files         196      196              
  Lines       14526    14549      +23     
==========================================
+ Hits        12567    12580      +13     
- Misses       1661     1669       +8     
- Partials      298      300       +2     

Impacted Files	Coverage Δ
pkg/reconciler/configuration/configuration.go	82.93% <0.00%> (-2.27%)	:arrow_down:
cmd/activator/main.go	0.00% <0.00%> (ø)
cmd/controller/main.go	0.00% <0.00%> (ø)
pkg/reconciler/gc/reconciler.go	100.00% <0.00%> (ø)
pkg/reconciler/nscert/nscert.go	72.03% <0.00%> (ø)
pkg/reconciler/labeler/labeler.go	100.00% <0.00%> (ø)
pkg/reconciler/service/service.go	88.03% <0.00%> (ø)
pkg/reconciler/autoscaling/hpa/hpa.go	91.66% <0.00%> (ø)
pkg/reconciler/autoscaling/kpa/kpa.go	95.26% <0.00%> (ø)
pkg/reconciler/domainmapping/reconciler.go	93.68% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[psschwei]

/ok-to-test

[norman465]

/cc evankanderson /cc cardil

[norman465]

/cc mchmarny

[mchmarny]

The test changes aligned to our previous discussions so all good on my side but I know @evankanderson has opinions here

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mchmarny, norman465

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~test/OWNERS~~ [evankanderson]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment