serving icon indicating copy to clipboard operation
serving copied to clipboard

Terminal API failures when creating child resources don't trigger Ready=False

Open dprotaso opened this issue 3 years ago • 1 comments

From https://github.com/knative/serving/issues/13053

A misplaced annotation prevented the SKS from being created since it failed validation. But this didn't cause the PodAutoscaler to flip to Ready=False.

There are probably other classes of this error throughout the codebase especially since any mutating webhook could inject a failure at any point. ie. rejecting deployment creation because of some security policy.

Note: terminal implies the creation/update requests will never succeed

dprotaso avatar Jul 18 '22 21:07 dprotaso

/triage accepted

dprotaso avatar Jul 18 '22 21:07 dprotaso