serving icon indicating copy to clipboard operation
serving copied to clipboard

[TEST-ONLY] Test filtering secret informer

Open skonto opened this issue 3 years ago • 6 comments

Proposed Changes

  • As in https://github.com/knative/serving/pull/12937.
  • Based on https://github.com/knative-sandbox/net-kourier/pull/862

skonto avatar Jun 24 '22 10:06 skonto

Codecov Report

Merging #13058 (3e0b432) into main (4695705) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13058      +/-   ##
==========================================
- Coverage   86.76%   86.75%   -0.01%     
==========================================
  Files         197      197              
  Lines       14485    14486       +1     
==========================================
  Hits        12568    12568              
- Misses       1621     1622       +1     
  Partials      296      296              
Impacted Files Coverage Δ
pkg/reconciler/revision/cruds.go 61.53% <0.00%> (-0.97%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4695705...3e0b432. Read the comment docs.

codecov[bot] avatar Jun 24 '22 10:06 codecov[bot]

/retest

skonto avatar Jun 24 '22 11:06 skonto

@nak3 I guess I have to wait for https://github.com/knative/serving/pull/13005 or apply it here to make the tls tests pass (exluding autotls) as I am building the net-kourier image from a branch of my PR that uses the new implementation eg. no fg.Network.ActivatorCA. Correct?

skonto avatar Jun 24 '22 14:06 skonto

Yes, you are correct. Sorry for this inconvenient.

nak3 avatar Jun 27 '22 09:06 nak3

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skonto To complete the pull request process, please assign psschwei after the PR has been reviewed. You can assign the PR to them by writing /assign @psschwei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jul 01 '22 12:07 knative-prow[bot]

@skonto: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot avatar Jul 06 '22 15:07 knative-prow-robot