serving icon indicating copy to clipboard operation
serving copied to clipboard
verified publisher icon knative

net-contour: rate limiting in contour HTTP Proxy spec

Open pramenn opened this issue 3 years ago • 4 comments

Describe the feature

I am currently using net contour controller config which does not support enabling rate limiting in contour HTTP Proxy spec for my knative services.

Http Proxy with global rate limiting example: https://projectcontour.io/docs/v1.21.0/config/rate-limiting/#global-rate-limiting Contour rate limiting design doc: https://github.com/projectcontour/contour/blob/main/design/ratelimit-design.md

configmap config-contour in knative-serving namespace should support contour HTTP Proxy rate liming spec.

pramenn avatar Jun 13 '22 21:06 pramenn

/area networking

pramenn avatar Jun 13 '22 21:06 pramenn

This is related to https://github.com/knative-sandbox/net-kourier/pull/759 (rate limiting for net-kourier).

What I am still debating is whether we should add it as a common API or not. I keep watching Gateway API's discussion https://github.com/kubernetes-sigs/gateway-api/issues/326 (as we will use the API in the future), but they also do not have the conclusion yet.

nak3 avatar Jun 14 '22 01:06 nak3

@nak3 Thanks.

PR is for net-kourier but I am using net-contour. Besides, PR only supports local rate limiting, is implementing global rate limiting descriptor on the roadmap?

pramenn avatar Jun 14 '22 16:06 pramenn

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Sep 13 '22 01:09 github-actions[bot]

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

knative-prow-robot avatar Oct 13 '22 23:10 knative-prow-robot

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jan 13 '23 01:01 github-actions[bot]

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

knative-prow-robot avatar Feb 12 '23 02:02 knative-prow-robot

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 15 '23 01:05 github-actions[bot]