Adding tests for Liveness probes

[Shashankft9]

Fixes #12480

Proposed Changes

• changing the readiness code in test_images to accommodate for liveness handler
• renaming few things in readiness tests
• adding tests for liveness probe

[codecov[bot]]

Codecov Report

Merging #12497 (44c79bd) into main (39af716) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12497      +/-   ##
==========================================
+ Coverage   87.46%   87.48%   +0.01%     
==========================================
  Files         195      195              
  Lines        9671     9718      +47     
==========================================
+ Hits         8459     8502      +43     
- Misses        928      931       +3     
- Partials      284      285       +1     

Impacted Files	Coverage Δ
pkg/activator/net/revision_backends.go	92.60% <0.00%> (-0.87%)	:arrow_down:
pkg/reconciler/revision/resources/queue.go	98.23% <0.00%> (-0.02%)	:arrow_down:
cmd/queue/main.go	0.53% <0.00%> (ø)
pkg/apis/serving/fieldmask.go	95.13% <0.00%> (+0.06%)	:arrow_up:
pkg/apis/serving/k8s_validation.go	93.61% <0.00%> (+0.14%)	:arrow_up:
pkg/apis/config/features.go	95.83% <0.00%> (+0.37%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39af716...44c79bd. Read the comment docs.

[Shashankft9]

cc @julz @nader-ziada I have only added tests with http get, let me know if there is a need for other types of probes as well, also any nits and improvements or suggestions appreciated!

[nader-ziada]

looks good to me, @psschwei can you take a look as well

[nader-ziada]

/cc @psschwei @dprotaso

[Shashankft9]

/hold

[knative-prow-robot]

New changes are detected. LGTM label has been removed.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shashankft9 To complete the pull request process, please ask for approval from psschwei after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/testing/OWNERS
• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/retest

[dprotaso]

@Shashankft9 you still have a hold on the PR - is it ready for another review?

[Shashankft9]

@dprotaso this is blocked by couple of issues: https://github.com/knative/serving/issues/12571 - where I am trying to deliberately fail the liveness probe and then check for the container to come back again, but it never happens. Test code for this is currently commented here: https://github.com/knative/serving/pull/12497/files#diff-6ad46d4cc76b719ef7ce89ac3997f8d85b7b0afe616f3071d7906406d7a139a0R119

https://github.com/knative/pkg/issues/2407

[knative-prow-robot]

@Shashankft9: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions[bot]]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.