ksvc should have ready condition status eq 'False' and reason eq 'ErrorConfig' if failing

[cardil]

This follow up on #11477. The error message is propagated, but the status isn't fully updated.

What version of Knative?

>= v0.24.0

Expected Behavior

When error such as dealt in #11477 occurs, the Ready condition (probably RoutesReady as well) should have status == 'False' and reason == 'ErrorConfig'

Example condition should look like:

{
  "lastTransitionTime": "2021-10-18T19:09:22Z",
  "message": "invalid domain name \"wathola-receiver-test-continuous-events-propagation-with-prober-zxmkp.apps.ksuszyns-325-ocp4x-aws-clean.openshift-aws.rhocf-dev.net\": url: Invalid value: \"wathola-receiver-test-continuous-events-propagation-with-prober-zxmkp\": must be no more than 63 characters",
  "reason": "ErrorConfig",
  "status": "False",
  "type": "Ready"
}

The kubectl should report:

$ kubectl get ksvc wathola-receiver
NAME               URL   LATESTCREATED            LATESTREADY              READY     REASON
wathola-receiver         wathola-receiver-00001   wathola-receiver-00001   False     ErrorConfig

Actual Behavior

Ready condition despite having full error message still shows reason and status as Unknown. That may lead to confusion.

Current, ready condition:

{
  "lastTransitionTime": "2021-10-18T19:09:22Z",
  "message": "invalid domain name \"wathola-receiver-test-continuous-events-propagation-with-prober-zxmkp.apps.ksuszyns-325-ocp4x-aws-clean.openshift-aws.rhocf-dev.net\": url: Invalid value: \"wathola-receiver-test-continuous-events-propagation-with-prober-zxmkp\": must be no more than 63 characters",
  "reason": "Unknown",
  "status": "Unknown",
  "type": "Ready"
}

The kubectl reports:

$ kubectl get ksvc wathola-receiver
NAME               URL   LATESTCREATED            LATESTREADY              READY     REASON
wathola-receiver         wathola-receiver-00001   wathola-receiver-00001   Unknown   Unknown

Steps to Reproduce the Problem

Same as in https://github.com/knative/serving/issues/11476

[cardil]

/cc @nak3

[cardil]

After https://github.com/kubernetes/community/blob/4c9ef2d/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

[cardil]

/remove-lifecycle stale

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

[skonto]

/remove-lifecycle stale

[skonto]

/reopen

[knative-prow[bot]]

@skonto: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skonto]

/triage accepted

[skonto]

In general I am in favor improving status messages to help users with debugging so I am re-opening this.