serving icon indicating copy to clipboard operation
serving copied to clipboard

Tracking issue for adding init container support

Open skonto opened this issue 4 years ago • 11 comments

Describe the feature

This is a placeholder for the feature track work described in the related doc:

Alpha (disabled by default):

  • [x] Add initContainers support in KService
  • [x] Add e2e test
  • [x] Add to listed flags here.
  • [x] Support init container image resolution
  • [x] Define defaults for init containers eg. container names (same as normal containers)

Beta (disabled by default):

  • [ ] Add conformance tests
  • [x] Update docs with a separate section for init container support

GA (disabled by default):

  • [ ] Add Knative CLI support

/cc @julz @dprotaso @markusthoemmes

Related tickets: #4307

skonto avatar Sep 20 '21 11:09 skonto

/assign @skonto

skonto avatar Sep 20 '21 11:09 skonto

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Feb 11 '22 01:02 github-actions[bot]

/remove-lifecycle stale

skonto avatar Feb 11 '22 11:02 skonto

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 13 '22 01:05 github-actions[bot]

/remove-lifecycle stale

skonto avatar May 13 '22 09:05 skonto

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 12 '22 01:08 github-actions[bot]

/reopen /lifecycle frozen

dprotaso avatar Sep 14 '22 13:09 dprotaso

@dprotaso: Reopened this issue.

In response to this:

/reopen /lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Sep 14 '22 13:09 knative-prow[bot]

@skonto the steps in

Beta (disabled by default):

seem to be done as:

  • the e2e test is already runs without alpha/beta flags
  • this feature is not part of the spec, so no conformance test needed
  • documentation already contains initContainers: https://knative.dev/docs/serving/configuration/feature-flags/#kubernetes-init-containers

ReToCode avatar Dec 15 '22 13:12 ReToCode

@ReToCode @dprotaso since there is no cli support should we move this feature to GA and close this ticket?

skonto avatar Oct 09 '23 08:10 skonto