serving icon indicating copy to clipboard operation
serving copied to clipboard
verified publisher icon knative

Tracking issue for adding support for volume type EmptyDir

Open skonto opened this issue 4 years ago • 11 comments

Describe the feature

This is a placeholder for the feature track work described in the related doc and targets EmptyDir support only:

Alpha (disabled by default):

  • [x] Add volume support for EmptyDir in KService
  • [x] Enable RW access and add e2e test
  • [x] Add to listed flags here.

Beta (enabled by default):

  • [x] Set conformance test for Beta
  • [ ] Set on by default

GA (Always on, cant be disabled):

  • [ ] Set always on
  • [ ] Add Knative CLI support (enhance --volume flag)

/cc @julz @dprotaso @markusthoemmes

Related tickets: #4417

skonto avatar Jul 13 '21 10:07 skonto

Add conformance tests

Adding anything to the conformance would require going through the Trademark committee. I have an umbrella issue for that.

dprotaso avatar Jul 13 '21 14:07 dprotaso

/assign @skonto

skonto avatar Jul 29 '21 07:07 skonto

I created a PR https://github.com/knative/specs/pull/72 to relax the conformance spec. Prior it restricted all volumes to be readonly. I've changed the language to defer the requirement to the volume's source.

dprotaso avatar Sep 15 '21 18:09 dprotaso

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Mar 16 '22 01:03 github-actions[bot]

@skonto where do we stand with this issue ? What is still left to be done ?

rhuss avatar Mar 16 '22 08:03 rhuss

@rhuss As described in the list above we need to finalize the beta phase and then move to GA. That means first turn on the feature by default with the flag available and at some point remove the flag to reach GA. We could omit the beta phase final step as the feature is already mature but removing the flag maybe an issue as potential users may dont want to allow that capability in there cluster. I will make the PR and see how this is going to be received by Serving folks.

skonto avatar Mar 16 '22 09:03 skonto

thanks! was just asking to prevent this issue from becoming closed as being stale ;-)

wrt/ to the client support mentioned above: Could you please open an issue over there to work on this support? Not sure if the client has support for volumes at all right now.

/remove-lifecycle stale

rhuss avatar Mar 16 '22 10:03 rhuss

Sure will do.

skonto avatar Mar 16 '22 10:03 skonto

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jun 15 '22 01:06 github-actions[bot]

/remove-lifecycle stale

skonto avatar Jun 15 '22 08:06 skonto

/triage accepted

dprotaso avatar Aug 02 '22 20:08 dprotaso

I checked the client implementation. Seems like the EmptyDir support is already fully covered:

  • https://github.com/knative/client/blob/main/pkg/kn/flags/podspec.go#L144
  • https://github.com/knative/client/blob/main/pkg/kn/flags/podspec.go#L157

@skonto. WDYT?

ReToCode avatar Dec 14 '22 12:12 ReToCode

Yes it seems the support was added here https://github.com/knative/client/pull/1679

skonto avatar Jan 17 '23 11:01 skonto

Yeah, so this issue is complete, right?

ReToCode avatar Jan 18 '23 08:01 ReToCode