pkg icon indicating copy to clipboard operation
pkg copied to clipboard

psbinding webhook leaks inclusion/exclusion lables

Open lberk opened this issue 5 years ago • 3 comments

Expected Behavior

Once all podspecable bindings are removed from a namespace, the webhook should remove the label to ensure we don't pollute the namespace

Actual Behavior

The psbinding reconcile leaves a bindings.knative.dev/include: true label on namespaces it touches

Steps to Reproduce the Problem

  1. create a compliant knative source & sink
  2. `k get ns -oyaml | grep

Additional Info

lberk avatar Apr 21 '20 17:04 lberk

One approach might be to ensure matching labels are removed if there are no remaining psObj's in the subject's namespace? /cc @mattmoor

lberk avatar Apr 21 '20 17:04 lberk

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 24 '20 16:08 github-actions[bot]

/lifecycle frozen

mattmoor avatar Aug 24 '20 16:08 mattmoor