operator icon indicating copy to clipboard operation
operator copied to clipboard

Revert "Propagate manifests paths earlier to operator status (#2106)"

Open dsimansk opened this issue 5 months ago • 3 comments

This reverts commit 2ac3a1eaad81a89738cd7c4d13b6374c0d198b3f.

Per my last comment on #2106. Let's make sure we can revert if needed. Otherwise I'll close based on outcomes of discussion.

/hold

dsimansk avatar Jun 20 '25 12:06 dsimansk

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 20 '25 12:06 knative-prow[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 62.16%. Comparing base (2ac3a1e) to head (cd1a2e2). :warning: Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2107   +/-   ##
=======================================
  Coverage   62.16%   62.16%           
=======================================
  Files          49       49           
  Lines        2318     2318           
=======================================
  Hits         1441     1441           
  Misses        785      785           
  Partials       92       92           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 20 '25 12:06 codecov[bot]

@dsimansk I so far did not see anything negatively influencing the operator with the patch merged before. Let's hold on this revert for now, before we find out anything else.

houshengbo avatar Jun 27 '25 09:06 houshengbo

@dsimansk @houshengbo is there any follow up here?

dprotaso avatar Aug 12 '25 19:08 dprotaso

@dsimansk @houshengbo is there any follow up here?

dprotaso avatar Sep 15 '25 15:09 dprotaso