hack icon indicating copy to clipboard operation
hack copied to clipboard

We should support generate CRDs in scripts like kubebuilder

Open zhaojizhuang opened this issue 4 years ago • 3 comments

We should support generate CRDs in scripts like kubebuilder or using kubebuilder

https://book.kubebuilder.io/reference/generating-crd.html

zhaojizhuang avatar Mar 08 '21 09:03 zhaojizhuang

cc @n3wscott @grantr

zhaojizhuang avatar Mar 09 '21 15:03 zhaojizhuang

We have the start of a tool, in use:

  • https://github.com/knative/eventing/pull/5087
  • https://github.com/knative-sandbox/discovery/pull/153

n3wscott avatar Mar 17 '21 18:03 n3wscott

Given this is standard practice for Operator SDK projects, in the meantime, would it make sense to add a section in the documentation/README.md titled "CRD Generation", and give contributors instructions on the current process, whether that be, "you create/update CRDs manually, here's some tools to help you do it", or whatever.

I've lost a good part of a day reading through the hack repository and other scripts within github.com/knative-sandbox/eventing-natts to be told via Knative Slack that CRDs aren't generated.

Happy to contribute this documentation, but I don't actually know what the process is yet. My next steps are to dig around #5087 but haven't got round to it yet.

dan-j avatar Nov 11 '21 12:11 dan-j