hack
hack copied to clipboard
Use `kube-codegen.sh` instead of `generate-groups.sh` when moving to k8s.io api `0.28+`
As of k8s.io/[email protected], the script generate-groups.sh is deprecated and we should move to using kube-codegen.sh
Related: #335
The Kube v0.30 removed the generate-groups.sh contents, which in turn renders Knative code-generation broken.
Knative already rolled to Kube v0.30, for example: https://github.com/knative/serving/pull/15462, https://github.com/knative/eventing/pull/8126, so this essentailly prevents changes to any Knative CRDs.
As discussed in the Productivity WG, I will create a generate-groups like tool in Knative ASAP, and notify Knative working groups on migration steps in all the Knative projects, that use code-gen.
/assign /kind bug
Thanks a lot, @cardil
Some maintainers already started doing the migration to kube_codegen.sh script:
- https://github.com/knative-extensions/eventing-istio/pull/486
- https://github.com/knative/eventing/pull/8183
- https://github.com/knative-extensions/security-guard/pull/312
And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.
We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ
/close
@cardil: Closing this issue.
In response to this:
Some maintainers already started doing the migration to kube_codegen.sh script:
- https://github.com/knative-extensions/eventing-istio/pull/486
- https://github.com/knative/eventing/pull/8183
- https://github.com/knative-extensions/security-guard/pull/312
And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.
We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.