hack icon indicating copy to clipboard operation
hack copied to clipboard

Use `kube-codegen.sh` instead of `generate-groups.sh` when moving to k8s.io api `0.28+`

Open andrew-su opened this issue 2 years ago • 1 comments

As of k8s.io/[email protected], the script generate-groups.sh is deprecated and we should move to using kube-codegen.sh

andrew-su avatar Oct 12 '23 14:10 andrew-su

Related: #335

andrew-su avatar Oct 12 '23 14:10 andrew-su

The Kube v0.30 removed the generate-groups.sh contents, which in turn renders Knative code-generation broken.

Knative already rolled to Kube v0.30, for example: https://github.com/knative/serving/pull/15462, https://github.com/knative/eventing/pull/8126, so this essentailly prevents changes to any Knative CRDs.

As discussed in the Productivity WG, I will create a generate-groups like tool in Knative ASAP, and notify Knative working groups on migration steps in all the Knative projects, that use code-gen.

/assign /kind bug

cardil avatar Aug 28 '24 12:08 cardil

Thanks a lot, @cardil

matzew avatar Aug 28 '24 15:08 matzew

Some maintainers already started doing the migration to kube_codegen.sh script:

  • https://github.com/knative-extensions/eventing-istio/pull/486
  • https://github.com/knative/eventing/pull/8183
  • https://github.com/knative-extensions/security-guard/pull/312

And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.

We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ

/close

cardil avatar Sep 02 '24 13:09 cardil

@cardil: Closing this issue.

In response to this:

Some maintainers already started doing the migration to kube_codegen.sh script:

  • https://github.com/knative-extensions/eventing-istio/pull/486
  • https://github.com/knative/eventing/pull/8183
  • https://github.com/knative-extensions/security-guard/pull/312

And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.

We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Sep 02 '24 13:09 knative-prow[bot]