func icon indicating copy to clipboard operation
func copied to clipboard

On-cluster build: Use unique PVC name used by a Pipeline

Open lance opened this issue 3 years ago • 6 comments

[UPDATE] by @zroubalik : Reasoning behind this: if for some reasons the PVC created for a function is not ready/healthy and we would like to re-create the function (or one with the same name) we won't be able to do so, because the Pipeline will fail on the PVC creation.

We can just append a random number to the PVC name, but we need to be sure that we are using the correct PVC for the function -> we need to track the generated name somewhere locally or maybe use a k8s labels to find out whether the PV for this function already exists.

lance avatar Feb 22 '22 17:02 lance

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 24 '22 01:05 github-actions[bot]

/remove-lifecycle stale

zroubalik avatar May 25 '22 10:05 zroubalik

@zroubalik what about other ideas like func deploy --remote --force or func deploy --remote --reset where it can mimic the behavior of func delete (or part of it)? In my opinion we should avoid "producing" too many temporary resources that need to be cleaned up later because they cause e.g. high storage consumption, e.g. the default size of a pvc on AWS with the EBS volume type is 1Gi and cannot be decreased even if our default size is 256Mi.

grafvonb avatar Mar 27 '23 06:03 grafvonb

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 17 '23 01:08 github-actions[bot]

/remove-lifecycle stale

lance avatar Aug 17 '23 16:08 lance

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Mar 08 '24 01:03 github-actions[bot]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jun 22 '24 01:06 github-actions[bot]