func icon indicating copy to clipboard operation
func copied to clipboard

`func create`: persist --language choice

Open omerbensaadon opened this issue 4 years ago • 10 comments

  • Give users the option to save the runtime as default (y/n)
  • Make sure to let them know where this is saved
  • Make sure the template always defaults to -c when not provided as a flag (-t)

omerbensaadon avatar Nov 05 '21 14:11 omerbensaadon

  • Make sure to let them know where this is saved

I don't think that's a great idea. I think the user should just be able to run func config global. See: https://github.com/knative-sandbox/kn-plugin-func/issues/573#issuecomment-962003540

lance avatar Nov 05 '21 16:11 lance

I will discuss this further with @lance this week, but the work I am doing on func invoke actually requires taking a bite out of the config situation: in particular opening the door to more conventional "config" settings, including git-like behavior of displaying a helpful message informing the user they need to choose a language, but can set a default via git config ... --global (exact syntax TBD)

lkingland avatar Nov 07 '21 10:11 lkingland

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Feb 06 '22 01:02 github-actions[bot]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 09 '22 01:05 github-actions[bot]

/remove-lifecycle stale

zroubalik avatar May 09 '22 11:05 zroubalik

To expand on this issue a bit, I was envisioning that the first time func is run, it will detect there is no user configuration, and the user will be prompted to run through a first-time setup, which is creating the global config (see #901). One of the questions asked of course being the user's preferred default language (if any).

lkingland avatar Jun 21 '22 13:06 lkingland

Should be resolved in https://github.com/knative-sandbox/kn-plugin-func/issues/901

lance avatar Aug 09 '22 13:08 lance

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jan 05 '23 01:01 github-actions[bot]

/remove-lifecycle stale

zroubalik avatar Jan 05 '23 09:01 zroubalik

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Mar 08 '24 01:03 github-actions[bot]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jun 22 '24 01:06 github-actions[bot]