func icon indicating copy to clipboard operation
func copied to clipboard

Help message of `kn func run` is misleading

Open rhuss opened this issue 4 years ago • 4 comments

kn func run -h
Run the function locally

Runs the function locally in the current directory or in the directory
specified by --path flag. The function must already have been built with the 'build' command.

What actually does locally mean ? Usually I would say, this would mean to execute the project locally on the Desktop but without Docker (like with npm run). But here it is meant to run in a Docker daemon which usually is not considered to be "local" (and in fact, on Windows or macOs Docker always runs in another VM). Not sure how to call it, but maybe "Run function image locally" ? (in contrast "Run function in the cluster")

Maybe this is just classical nit-picking, feel free to close the issue if you don't see this as relevant.

rhuss avatar Oct 20 '21 05:10 rhuss

in fact, on Windows or macOs Docker always runs in another VM

Yes, but users are abstracted away from that, aren't they (I use only Linux)?

matejvasek avatar Oct 20 '21 11:10 matejvasek

Yes, but users are abstracted away from that, aren't they (I use only Linux)?

sometimes yes, sometimes not. E.g. when using minikube your VM has an extra IP to reach the docker daemon (via TCP socket). Still I wonder how one could differentiate between 'local local' and 'local docker' :)

rhuss avatar Oct 20 '21 12:10 rhuss

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jan 19 '22 01:01 github-actions[bot]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 30 '24 01:08 github-actions[bot]