Fix/type args diff

[intojhanurag]

Fix: #3085

[knative-prow[bot]]

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov[bot]]

Codecov Report

:x: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.11%. Comparing base (83ea554) to head (9819610). :warning: Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/invoke.go	20.00%	3 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
+ Coverage   59.37%   60.11%   +0.73%     
==========================================
  Files         134      134              
  Lines       13500    13522      +22     
==========================================
+ Hits         8016     8129     +113     
+ Misses       4540     4422     -118     
- Partials      944      971      +27     

Flag	Coverage Δ
e2e-tests	41.64% <20.00%> (+1.42%)	:arrow_up:
integration-tests	54.65% <20.00%> (+1.66%)	:arrow_up:
unit-tests	46.70% <20.00%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[intojhanurag]

Hey @gauron99 , Can you take a look on this one , if you have a moment ?

[gauron99]

@lkingland I think we should actually promote the single case in both format (--format) and templates (--template) instead? (internally we support both with singular AND plural and we just overwrite the plural in cli) Basically the other way around than this PR.

WDYT?

[lkingland]

Yes. I agree. Plurality is not easily understood for folks with english as a second language, so I would suggest we accept both in the CLI, but be strict in the "core", accepting only the singular.

It will be so nice to have this standardized!

[intojhanurag]

Hey @gauron99 , what I need to do ? Please lmk if anything .

[gauron99]

It would be good to implement the reverse as we discussed with Luke @intojhanurag

[intojhanurag]

Hey @gauron99 , I reversed the logic .

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [lkingland]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment