func icon indicating copy to clipboard operation
func copied to clipboard

feat: add interactive prompts for builder, push, and builder image options

Open intojhanurag opened this issue 2 months ago • 6 comments

Changes

Adds interactive prompts to func build --confirm for additional build options, including:

  • Builder selection (--builder)
  • Push option (--push)
  • Builder image (--builder-image)
  • Base image (--base-image)

Before

Screenshot 2025-10-26 124916

After

Screenshot 2025-10-26 124222

intojhanurag avatar Oct 26 '25 07:10 intojhanurag

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 26 '25 07:10 knative-prow[bot]

Codecov Report

:x: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.02%. Comparing base (39c321d) to head (a583f58). :warning: Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
cmd/build.go 0.00% 27 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
+ Coverage   59.39%   60.02%   +0.62%     
==========================================
  Files         134      134              
  Lines       13495    13540      +45     
==========================================
+ Hits         8016     8128     +112     
+ Misses       4538     4442      -96     
- Partials      941      970      +29     
Flag Coverage Δ
e2e-tests 41.55% <0.00%> (+1.32%) :arrow_up:
integration-tests 54.57% <0.00%> (+1.56%) :arrow_up:
unit-tests 46.63% <0.00%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 26 '25 07:10 codecov[bot]

Hmm Im thinking to include only the necessary options. Keep the optional ones out of the prompts. (remove the builderImage and base image since its only host builder -- or do a conditional check for baseImage only if host builder is used.

gauron99 avatar Oct 30 '25 18:10 gauron99

/ok-to-test

gauron99 avatar Oct 30 '25 18:10 gauron99

Hey @gauron99 , I added the all suggestion. Please take a look on it .

intojhanurag avatar Nov 03 '25 09:11 intojhanurag

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Nov 11 '25 06:11 knative-prow[bot]