func icon indicating copy to clipboard operation
func copied to clipboard

Fix InsecureSSL default for GitHub webhooks

Open intojhanurag opened this issue 2 months ago • 6 comments

Changed InsecureSSL from "1" (insecure) to "0" (secure) to ensure SSL certificates are properly verified by default.

intojhanurag avatar Oct 25 '25 06:10 intojhanurag

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 25 '25 06:10 knative-prow[bot]

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 25 '25 06:10 knative-prow[bot]

Codecov Report

:x: Patch coverage is 0% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.12%. Comparing base (3d1ee5e) to head (fa82bb5). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/git/github/github.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3148      +/-   ##
==========================================
+ Coverage   59.35%   60.12%   +0.76%     
==========================================
  Files         134      134              
  Lines       13519    13519              
==========================================
+ Hits         8024     8128     +104     
+ Misses       4552     4420     -132     
- Partials      943      971      +28     
Flag Coverage Δ
e2e-tests 41.62% <0.00%> (+1.42%) :arrow_up:
integration-tests 54.65% <0.00%> (+1.65%) :arrow_up:
unit-tests 46.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 25 '25 06:10 codecov[bot]

/retest

gauron99 avatar Oct 30 '25 18:10 gauron99

/ok-to-test

gauron99 avatar Oct 30 '25 18:10 gauron99

@matejvasek @lkingland can we do this? not sure if it used to break something beforehand or why havent we done this prior

gauron99 avatar Oct 30 '25 18:10 gauron99