func icon indicating copy to clipboard operation
func copied to clipboard

Add TypeScript linting to templates

Open intojhanurag opened this issue 1 month ago • 15 comments

Description

This PR adds ESLint checks for TypeScript templates (http and cloudevents) to ensure code quality. It updates the Makefile with a new target check-typescript and includes it in check-templates.

Changes

  • Runs npm ci and npx eslint --ext .ts . for both templates
  • Cleans up node_modules and build artifacts after linting

intojhanurag avatar Oct 25 '25 05:10 intojhanurag

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 25 '25 05:10 knative-prow[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.16%. Comparing base (b2b8009) to head (d16615a). :warning: Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
+ Coverage   59.39%   60.16%   +0.77%     
==========================================
  Files         134      134              
  Lines       13500    13500              
==========================================
+ Hits         8018     8122     +104     
+ Misses       4539     4407     -132     
- Partials      943      971      +28     
Flag Coverage Δ
e2e-tests 41.68% <ø> (+1.46%) :arrow_up:
integration-tests 54.69% <ø> (+1.67%) :arrow_up:
unit-tests 46.73% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 25 '25 05:10 codecov[bot]

Hey @gauron99 , Can u have alook when you have some moments . I rebased as you recommended but still that verify test cases is failing .

intojhanurag avatar Oct 25 '25 05:10 intojhanurag

/retest

gauron99 avatar Oct 30 '25 18:10 gauron99

/ok-to-test

gauron99 avatar Oct 30 '25 18:10 gauron99

/retest

gauron99 avatar Nov 01 '25 12:11 gauron99

/lgtm /approve

gauron99 avatar Nov 01 '25 12:11 gauron99

/test

gauron99 avatar Nov 01 '25 21:11 gauron99

@gauron99: The /test command needs one or more targets. The following commands are available to trigger required jobs:

/test unit-tests

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Nov 01 '25 21:11 knative-prow[bot]

/retest

gauron99 avatar Nov 01 '25 21:11 gauron99

please rebase on main latest changes, that will fix the verify

gauron99 avatar Nov 01 '25 21:11 gauron99

Hey @gauron99 , I reabased . I don't know what is happening ?

intojhanurag avatar Nov 02 '25 05:11 intojhanurag

/retest

gauron99 avatar Nov 04 '25 07:11 gauron99

Hey @gauron99 , all tests has been passed , please take a look on it if you have a moment.

intojhanurag avatar Nov 05 '25 08:11 intojhanurag

/lgtm /approve

gauron99 avatar Nov 05 '25 08:11 gauron99

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, intojhanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Nov 05 '25 08:11 knative-prow[bot]