func icon indicating copy to clipboard operation
func copied to clipboard

Add StartTimeout handling to Docker Runner

Open intojhanurag opened this issue 2 months ago • 4 comments

Description

This PR adds StartTimeout support to the Docker Runner (pkg/docker/runner.go).
The Runner now waits for the container to become ready within a configurable timeout and returns an error if it does not start in time.

intojhanurag avatar Oct 23 '25 09:10 intojhanurag

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 23 '25 09:10 knative-prow[bot]

Codecov Report

:x: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.69%. Comparing base (b990215) to head (7f0006f). :warning: Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
pkg/docker/runner.go 50.00% 8 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3135      +/-   ##
==========================================
+ Coverage   58.31%   58.69%   +0.38%     
==========================================
  Files         134      134              
  Lines       17377    17397      +20     
==========================================
+ Hits        10134    10212      +78     
+ Misses       6302     6214      -88     
- Partials      941      971      +30     
Flag Coverage Δ
e2e-tests 40.26% <50.00%> (+1.36%) :arrow_up:
integration-tests 54.72% <52.94%> (+2.46%) :arrow_up:
unit-tests 46.16% <0.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 23 '25 09:10 codecov[bot]

Hey @gauron99 , Please can you review this one ? if you have a moment.

intojhanurag avatar Nov 06 '25 18:11 intojhanurag

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Nov 11 '25 06:11 knative-prow[bot]