func icon indicating copy to clipboard operation
func copied to clipboard

[WIP]feat: use upstream scaffolding for go

Open gauron99 opened this issue 1 month ago • 6 comments

Changes

  • :broom: Remove the use of old go scaffolding with pack builder

/kind cleanup Fixes https://github.com/knative/func/issues/3005

gauron99 avatar Oct 05 '25 13:10 gauron99

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

knative-prow[bot] avatar Oct 05 '25 13:10 knative-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 05 '25 13:10 knative-prow[bot]

Codecov Report

:x: Patch coverage is 59.32203% with 24 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 51.83%. Comparing base (a23f6d8) to head (11093ef). :warning: Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/builder.go 35.29% 20 Missing and 2 partials :warning:
pkg/k8s/dialer.go 50.00% 1 Missing :warning:
pkg/pipelines/tekton/tasks.go 91.66% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
+ Coverage   51.82%   51.83%   +0.01%     
==========================================
  Files         162      162              
  Lines       19131    19188      +57     
==========================================
+ Hits         9914     9947      +33     
- Misses       8240     8262      +22     
- Partials      977      979       +2     
Flag Coverage Δ
integration 17.96% <41.02%> (+0.05%) :arrow_up:
unit macos-14 44.36% <41.02%> (-0.01%) :arrow_down:
unit macos-latest 44.36% <41.02%> (-0.01%) :arrow_down:
unit ubuntu-24.04-arm 44.56% <45.76%> (+0.01%) :arrow_up:
unit ubuntu-latest 45.30% <41.02%> (-0.02%) :arrow_down:
unit windows-latest 44.39% <41.02%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 05 '25 13:10 codecov[bot]

/retest

gauron99 avatar Oct 16 '25 15:10 gauron99

/retest

gauron99 avatar Oct 16 '25 15:10 gauron99

/retest

gauron99 avatar Oct 17 '25 03:10 gauron99

/retest

gauron99 avatar Nov 10 '25 16:11 gauron99

/retest

gauron99 avatar Nov 20 '25 08:11 gauron99

/test all

gauron99 avatar Nov 20 '25 08:11 gauron99