func icon indicating copy to clipboard operation
func copied to clipboard

Fix context object

Open cezar77 opened this issue 2 months ago • 14 comments

Changes

The description of the Context object in the README.md contains a redundant paragraph. The JSDoc is missing the parameters httpVersionMajor and httpVersionMinor.

  • :broom: Update or clean up current behavious

/kind cleanup

Fixes #3033

Release Note

Update the Context object in the JSDoc with the missing params httpVersionMajor and httpVersionMinor.
Remove redundant paragraph in the description of the Context object in the README.

Docs


cezar77 avatar Sep 09 '25 10:09 cezar77

CLA Not Signed

  • :white_check_mark: login: matejvasek / name: Matej Vašek (75adf4d03b0f7ca28f1d176284132991b5ee4914)
  • :x: - login: @cezar77 / name: Cezar Pendarovski . The commit (38631debbf343b64d3b0c4cc23e4e7ad793174a3, 709a155fe8a9c67c64d4d427bbfc30726c8d8e5e) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

Hi @cezar77. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Sep 09 '25 10:09 knative-prow[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.20%. Comparing base (c23e8cf) to head (75adf4d). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3034      +/-   ##
==========================================
+ Coverage   58.46%   59.20%   +0.74%     
==========================================
  Files         134      134              
  Lines       17251    17251              
==========================================
+ Hits        10085    10213     +128     
+ Misses       6234     6078     -156     
- Partials      932      960      +28     
Flag Coverage Δ
e2e-tests 40.39% <ø> (+1.34%) :arrow_up:
integration-tests 53.94% <ø> (+1.64%) :arrow_up:
unit-tests 46.28% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 16 '25 13:09 codecov[bot]

/ok-to-test

matejvasek avatar Oct 09 '25 15:10 matejvasek

/retest-required

matejvasek avatar Oct 09 '25 15:10 matejvasek

/override unit-tests_func_main /approve /lgtm

matejvasek avatar Oct 09 '25 16:10 matejvasek

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads.

In response to this:

/override unit-tests_func_main /approve /lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 09 '25 16:10 knative-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezar77, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 09 '25 16:10 knative-prow[bot]

@gauron99 @lkingland plz override unit-tests_func_main

matejvasek avatar Oct 10 '25 11:10 matejvasek

/override unit-tests_func_main

gauron99 avatar Oct 10 '25 11:10 gauron99

@gauron99: Overrode contexts on behalf of gauron99: unit-tests_func_main

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 10 '25 11:10 knative-prow[bot]

still need the CLA

gauron99 avatar Oct 10 '25 11:10 gauron99

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Oct 13 '25 15:10 knative-prow-robot

@cezar77 you need to sign CLA.

matejvasek avatar Oct 17 '25 11:10 matejvasek