func icon indicating copy to clipboard operation
func copied to clipboard

Fix node jsdoc

Open cezar77 opened this issue 2 months ago • 14 comments

Changes

In the file http/index.js in the node template a link to the context object is provided, but this link is dead and leads to 404. In this PR we update the link to point to the correct location.

  • :bug: Fix bug

/kind bug

Fixes #3031

Release Note

Update the link to the Context object in the JSDoc in the file index.js for the node template.

Docs


cezar77 avatar Sep 09 '25 08:09 cezar77

CLA Not Signed

  • :white_check_mark: login: matejvasek / name: Matej Vašek (ac32597dfe9f713df9ed2a7caca82278ab72da00)
  • :x: - login: @cezar77 / name: Cezar Pendarovski . The commit (8b0d27e4ae76fede2e77b76a7445c9dabc93d2eb, b9206a8973a966de41736251fc2bcb86cfda938a) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

Welcome @cezar77! It looks like this is your first PR to knative/func 🎉

knative-prow[bot] avatar Sep 09 '25 08:09 knative-prow[bot]

Hi @cezar77. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Sep 09 '25 08:09 knative-prow[bot]

Thanks for the submission! You'll need to follow the prompts on the EasyCLA thing before we can merge

lkingland avatar Sep 16 '25 13:09 lkingland

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.18%. Comparing base (c23e8cf) to head (ac32597). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
+ Coverage   58.46%   59.18%   +0.72%     
==========================================
  Files         134      134              
  Lines       17251    17251              
==========================================
+ Hits        10085    10210     +125     
+ Misses       6234     6080     -154     
- Partials      932      961      +29     
Flag Coverage Δ
e2e-tests 40.39% <ø> (+1.34%) :arrow_up:
integration-tests 53.94% <ø> (+1.64%) :arrow_up:
unit-tests 46.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 16 '25 13:09 codecov[bot]

/override unit-tests_func_main

matejvasek avatar Oct 09 '25 16:10 matejvasek

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads.

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 09 '25 16:10 knative-prow[bot]

/approve /lgtm

matejvasek avatar Oct 09 '25 16:10 matejvasek

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezar77, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 09 '25 16:10 knative-prow[bot]

@gauron99 @lkingland plz override unit-tests_func_main

matejvasek avatar Oct 10 '25 11:10 matejvasek

/override unit-tests_func_main

gauron99 avatar Oct 10 '25 11:10 gauron99

@gauron99: Overrode contexts on behalf of gauron99: unit-tests_func_main

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 10 '25 11:10 knative-prow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Oct 13 '25 15:10 knative-prow-robot

@cezar77 you need to sign CLA.

matejvasek avatar Oct 17 '25 11:10 matejvasek