func icon indicating copy to clipboard operation
func copied to clipboard

fix: hotfix remote python with pack builder deploy

Open gauron99 opened this issue 3 months ago • 5 comments

  • This is a hotfix for the remote python pack deployment.
  • Implements the "python injector" workaround for remote as well.
  • Please note that this is bound to change! with a larger scale re-do of the scaffolding implementation (the injector wont be needed at all)

fixes https://github.com/knative/func/issues/2985

gauron99 avatar Aug 28 '25 06:08 gauron99

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

knative-prow[bot] avatar Aug 28 '25 06:08 knative-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Aug 28 '25 06:08 knative-prow[bot]

Codecov Report

:x: Patch coverage is 33.64486% with 71 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.82%. Comparing base (fa769ca) to head (ce4e875). :warning: Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
pkg/pipelines/tekton/pipelines_provider.go 6.57% 69 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
+ Coverage   58.72%   58.82%   +0.10%     
==========================================
  Files         132      132              
  Lines       16955    17041      +86     
==========================================
+ Hits         9957    10025      +68     
+ Misses       6069     6055      -14     
- Partials      929      961      +32     
Flag Coverage Δ
e2e-tests 33.16% <0.00%> (-6.45%) :arrow_down:
integration-tests 54.06% <33.64%> (+1.46%) :arrow_up:
unit-tests 46.29% <33.64%> (-0.15%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 28 '25 06:08 codecov[bot]

This does fix the immediate issue of direct upload remote deployment ( deploy local code to cluster ) with python + pack but the "hacky" changes do fail the non-direct upload (using the git deployment) therefore instead of digging further into this temporary hack - Im going to start the subsequent work immediately of the scaffolding rework, which will include the python + pack fix.

If you are reading this coming from the issue linked, please feel free to pull this PR branch and use the python+pack remote deployment when using local code in the meantime! Thank you for understanding.

closes issue to track is https://github.com/knative/func/issues/3005

gauron99 avatar Aug 29 '25 07:08 gauron99

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Oct 20 '25 05:10 knative-prow-robot