func icon indicating copy to clipboard operation
func copied to clipboard

fix: affinity/coschedule tekton issues

Open matejvasek opened this issue 3 months ago • 7 comments

Changes

  • :bug: All tekton tasks have identical workspace list/set.

/kind bug

fix: affinity/coscheduling issues of tekton tasks

matejvasek avatar Aug 07 '25 12:08 matejvasek

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Workspace set must be identical for all the tasks. Having strict subset of workspaces clearly does not work.

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Aug 07 '25 12:08 knative-prow[bot]

/lgtm

jrangelramos avatar Aug 07 '25 12:08 jrangelramos

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.30%. Comparing base (aeb51b3) to head (be429f2). :warning: Report is 134 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2972      +/-   ##
==========================================
+ Coverage   58.93%   59.30%   +0.36%     
==========================================
  Files         132      132              
  Lines       16935    16956      +21     
==========================================
+ Hits         9981    10055      +74     
+ Misses       6025     5942      -83     
- Partials      929      959      +30     
Flag Coverage Δ
e2e-tests 33.33% <0.00%> (-6.31%) :arrow_down:
integration-tests 54.51% <100.00%> (+1.74%) :arrow_up:
unit-tests 46.68% <100.00%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 07 '25 12:08 codecov[bot]

plz re-lgtm @jrangelramos

matejvasek avatar Aug 07 '25 14:08 matejvasek

/test unit-tests

matejvasek avatar Aug 07 '25 16:08 matejvasek

The GitHub UI does not have rerunning the tests as an option. Perhaps submitting a rebase will get it un-stuck?

lkingland avatar Sep 05 '25 02:09 lkingland

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Sep 05 '25 02:09 knative-prow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Nov 20 '25 15:11 knative-prow-robot