func
func copied to clipboard
[wip] Support multiple triggers on func subscribe command
Changes
- :gift: Support multi triggers on func subcribe command
/kind enhancement
Fixes #2572
Release Note
Docs
@jrangelramos: The label(s) kind/enhancmeent cannot be applied, because the repository doesn't have them.
In response to this:
Changes
- :gift: Support multi triggers on func subcribe command
/kind enhancmeent
Fixes #2572
Release Note
Docs
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jrangelramos
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jrangelramos]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
:x: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.61%. Comparing base (e013e6e) to head (8f60d4c).
:warning: Report is 152 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| cmd/subscribe.go | 80.64% | 5 Missing and 1 partial :warning: |
:exclamation: There is a different number of reports uploaded between BASE (e013e6e) and HEAD (8f60d4c). Click for more details.
HEAD has 5 uploads less than BASE
Flag BASE (e013e6e) HEAD (8f60d4c) 1 0 unit-tests-macos-latest 1 0 unit-tests-ubuntu-latest 1 0 integration-tests 1 0 unit-tests-windows-latest 1 0
Additional details and impacted files
@@ Coverage Diff @@
## main #2816 +/- ##
===========================================
- Coverage 61.59% 44.61% -16.99%
===========================================
Files 131 110 -21
Lines 15794 14976 -818
===========================================
- Hits 9728 6681 -3047
- Misses 5155 7484 +2329
+ Partials 911 811 -100
| Flag | Coverage Δ | |
|---|---|---|
| e2e-test | 35.38% <80.64%> (+0.03%) |
:arrow_up: |
| e2e-test-oncluster | 33.72% <0.00%> (+1.34%) |
:arrow_up: |
| e2e-test-oncluster-runtime | 28.16% <0.00%> (?) |
|
| e2e-test-runtime-go | 25.74% <0.00%> (?) |
|
| e2e-test-runtime-node | 25.09% <0.00%> (?) |
|
| e2e-test-runtime-quarkus | 25.18% <0.00%> (?) |
|
| e2e-test-runtime-rust | 24.65% <0.00%> (?) |
|
| e2e-test-runtime-springboot | 24.72% <0.00%> (?) |
|
| e2e-test-runtime-typescript | 25.18% <0.00%> (?) |
|
| integration-tests | ? |
|
| unit-tests-macos-latest | ? |
|
| unit-tests-ubuntu-latest | ? |
|
| unit-tests-windows-latest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Hi @jrangelramos . Looking good so far. A few legitimately failing tests, however.
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.